[PATCH] D56553: [WebAssembly] Support multilibs for wasm32

Mon Jan 14 12:00:00 PST 2019

sunfish marked an inline comment as done.
sunfish added a comment.

In D56553#1356467 <https://reviews.llvm.org/D56553#1356467>, @sbc100 wrote:

> Ooo - a new OS is born!

> Perhaps create a separate change to introduce the new OS?   .. which will then make this CL tiny and specific to what the CL title says it is doing.

Without the new OS I wouldn't be able to fully test the new functionality, as we have no other wasm OS's in tree. Is the size of this patch an issue?

================
Comment at: tools/clang/lib/Driver/ToolChains/WebAssembly.cpp:95
+    const std::string MultiarchTriple = getMultiarchTriple(D, Triple, SysRoot);
+    getFilePaths().push_back(getDriver().SysRoot + "/lib/" + MultiarchTriple);
+  }
----------------
sbc100 wrote:
> For include paths you have `multiarch` + `default` but for library paths you have `multiarch` *or* `default`.  Is that deliberate?
Yes; I followed https://wiki.debian.org/Multiarch/Implementation . "include" can contain platform-independent headers, while libraries are inherently platform-dependent.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56553/new/

https://reviews.llvm.org/D56553