[PATCH] D56435: We can improve the performance (generally) by memo-izing the action to map a debug location to its function summary.

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 14 11:58:10 PST 2019


wmi added a comment.

> Seems the compile time saving is got mainly because there are multiple instructions sharing the same debug location, is my understanding correct?

Seems incorrect. findFunctionSamples may be called for the same instruction multiple times due to multiple iterations of hot functions inlining or profile propagation.

But we can still clean up the map at the end of runOnFunction.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56435/new/

https://reviews.llvm.org/D56435





More information about the llvm-commits mailing list