[PATCH] D56553: [WebAssembly] Support multilibs for wasm32

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 14 10:30:15 PST 2019


sbc100 added a comment.

Ooo - a new OS is born!

Perhaps create a separate change to introduce the new OS?   .. which will then make this CL tiny and specific to what the CL title says it is doing.



================
Comment at: tools/clang/lib/Driver/ToolChains/WebAssembly.cpp:95
+    const std::string MultiarchTriple = getMultiarchTriple(D, Triple, SysRoot);
+    getFilePaths().push_back(getDriver().SysRoot + "/lib/" + MultiarchTriple);
+  }
----------------
For include paths you have `multiarch` + `default` but for library paths you have `multiarch` *or* `default`.  Is that deliberate?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56553/new/

https://reviews.llvm.org/D56553





More information about the llvm-commits mailing list