[PATCH] D54590: [compiler-rt][UBSan] Sanitization for alignment assumptions.

[Matt Morehouse via Phabricator via llvm-commits]

morehouse accepted this revision.
morehouse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/ubsan/ubsan_handlers.h:32
+};
+
 #define UNRECOVERABLE(checkname, ...) \
----------------
Nit:  Let's move this to right before the matching RECOVERABLE line below.


================
Comment at: test/ubsan/TestCases/Pointer/alignment-assumption-attribute-align_value-on-lvalue.cpp:23
+  struct ac_struct x;
+  x.a = argv; // FIXME: it is weird that this does not also have an assumption.
+  load_from_ac_struct(&x);
----------------
Any idea why the assignment doesn't trigger a report while the unused return value does?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54590/new/

https://reviews.llvm.org/D54590