[PATCH] D56569: [ObjectYAML][yaml2obj][ELF] Add basic support for dynamic entries

[Armando Montanez via Phabricator via llvm-commits]

amontanez marked 2 inline comments as done.
amontanez added inline comments.


================
Comment at: llvm/tools/yaml2obj/yaml2elf.cpp:740-741
+template <class ELFT> bool ELFState<ELFT>::hasDynamicEntries() const {
+  if (hasDynamicSymbols())
+    return true;
+
----------------
jhenderson wrote:
> I'm unconvinced by this line here, unless you're going to auto-populate the dynamic section with tags such as DT_SYMTAB in this case.
That was the original goal, it just wasn't included in the patch. I've adjusted the implicit section names for now since that functionality isn't added yet.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56569/new/

https://reviews.llvm.org/D56569