[PATCH] D56206: Introduce `RemoteAddressSpaceView` and `VMReadContext`.
Dan Liew via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 14 08:52:55 PST 2019
delcypher marked 6 inline comments as done and 2 inline comments as done.
delcypher added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_vm_read_context.h:73
+ // process in which it is being called from.
+ bool IsLocal() const { return is_local; }
+
----------------
vitalybuka wrote:
> If you can calculate it from target_process please remove member and simplify state
We cannot calculate it. It needs to be part of the sate.
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56206/new/
https://reviews.llvm.org/D56206
More information about the llvm-commits
mailing list