[PATCH] D52002: Omit range checks from jump tables when lowering switches with unreachable default

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 14 07:40:35 PST 2019


hans added a comment.

Sorry for the long delay. I'm back from vacation now, and I'll commit this tomorrow morning unless anyone else objects.



================
Comment at: test/CodeGen/X86/switch-jump-table.ll:5
 
 ; An unreachable default destination is replaced with the most popular case label.
 
----------------
This comment describes the old behavior. After your patch, we don't do the "replace with most popular case label" thing anymore, but just omit the range check, so please update the comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52002/new/

https://reviews.llvm.org/D52002





More information about the llvm-commits mailing list