[PATCH] D56151: [DebugInfo] PR40010: Avoid register coalesing altering DBG_VALUE valuations

[Jeremy Morse via Phabricator via llvm-commits]

jmorse marked an inline comment as done.
jmorse added inline comments.


================
Comment at: lib/CodeGen/RegisterCoalescer.cpp:248
+    /// When merging SrcReg and DstReg together, and the operand of the
+    /// specified DBG_VALUE refers to one of them, would the valuation of the
+    /// DBG_VALUE change? This can happen when the DBG_VALUEs operand is dead
----------------
aprantl wrote:
> `valuation` is not a term we typically use in this context? Perhaps `should the operands of the DBG_VALUE be updated`?
Updated with some new text -- I've gone for "would the def that a DBG_VALUE refers to change?", which should be precise about what the function tests for.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56151/new/

https://reviews.llvm.org/D56151