[PATCH] D55185: [Clangd] Index main-file symbols (bug 39761)

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 14 02:13:56 PST 2019


sammccall added a comment.

The forward-declaration-in-main-file case:
In principle, if the definition is missing, I think we should treat these differently (not index them, or treat them as visible-outside file) because they're almost certainly declared "properly" elsewhere.
@ilya-biryukov convinced me offline that this isn't a big deal in practice as forward declarations in main-files (and not subsequently defining the symbol) aren't that useful.
So going to avoid patching that, as there might be unintended consequences.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55185/new/

https://reviews.llvm.org/D55185





More information about the llvm-commits mailing list