[PATCH] D56638: [llgo]: Somewhat revive it and make it buildable with current trunk.

[Kristina Brooks via Phabricator via llvm-commits]

kristina marked an inline comment as done.
kristina added a comment.

Currently actual tests would require using `libgcc`, as `compiler-rt` does not support split stack yet. If `libgcc` is required for tests then I don't think I can accurately make one. So if you require a test for this, it's likely that I'll have to mark this as "Changes Planned" for now until `compiler-rt` is sufficient to link this, unfortunately. Up to you really, though in my opinion even without tests this is better than it failing to compile. And the reasons for avoiding `libgcc` are fairly complicated, my intentions currently are to stay as far away from GNU runtime components as possible.



================
Comment at: cmd/gllgo/gllgo.go:201
 	triple          string
+	splitStack      bool
 }
----------------
pcc wrote:
> I don't see where this is used.
Currently it's not, in this patch, so I can revise it to remove it. Though flags still need to be handled.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56638/new/

https://reviews.llvm.org/D56638