[PATCH] D54498: AbstractCallSite -- A unified interface for (in)direct and callback calls

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM.  I'm approving this because I think it's reached the point of being a very meaningful step in the right direction, but there are a couple of required follow ups which need to happen in following patches.  Specifically:

1. Add Verifier support.  This should subsume most of the asserts you have on interpreting the metadata.
2. Add tests covering both basic syntax parsing, and merge semantics.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54498/new/

https://reviews.llvm.org/D54498