[PATCH] D56637: [llvm-objdump] - Cleanup the code. NFCI.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jan 12 07:00:18 PST 2019
grimar created this revision.
grimar added a reviewer: jhenderson.
Herald added subscribers: mgrang, aheejin.
This is an initial NFC cleanup for the llvm-objdump code.
This patch:
1. Renames things to match the official LLVM code style (lower case -> upper case).
2. Removes few obviously excessive variables.
3. Moves a few lines closer to the place of use, reorders the code a bit to simplify it, to avoid doing excessive returns and to avoid using 'else` after returns.
- I tried to focus only on a llvm-objdump.h/llvm-objdump.cpp files. Few changes in the
MachODump.cpp and COFFDump.cpp are a result of llvm-objdump.h modification.
- My intention wasn't about doing any significant code refactorings in this patch.
https://reviews.llvm.org/D56637
Files:
COFFDump.cpp
MachODump.cpp
llvm-objdump.cpp
llvm-objdump.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56637.181440.patch
Type: text/x-patch
Size: 48875 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190112/cae3bfc5/attachment.bin>
More information about the llvm-commits
mailing list