[PATCH] D56401: [WebAssembly] Fix updating/moving DBG_VALUEs in RegStackify

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

In D56401#1354321 <https://reviews.llvm.org/D56401#1354321>, @yurydelendik wrote:

> In D56401#1353800 <https://reviews.llvm.org/D56401#1353800>, @aheejin wrote:
>
> > Oh and I think we need test cases for
> >
> > 1. Rematerializing a def in another BB that has DBG_VALUE attached
>
>
> Yep, still working on this one
>
> > 2. LOCAL_TEE case within a BB that has multiple defs to the same register (as in the current test case), to see `clone()` is working
>
> The test in llvm/test/DebugInfo/WebAssembly/dbg-value-move-2.ll . Would you like to see it in MIR format?


Is this a case that you rematerialize an instruction from another BB and move its DBG_VALUE along with it? I don't think so, because the earlier code didn't handle this case and this test was still passing.



================
Comment at: lib/Target/WebAssembly/WebAssemblyUtilities.cpp:389
+    DBI->eraseFromParent();
+}
----------------
Sorry, looking at the size of class, I guess it deserves an own file of its own, like DebugValueManager.cpp/h, other than putting this into Utilities. Sorry for going back and forth.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56401/new/

https://reviews.llvm.org/D56401