[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 11 14:23:18 PST 2019


krytarowski added a comment.

In D56215#1350179 <https://reviews.llvm.org/D56215#1350179>, @ruiu wrote:

> To be honest, I don't think I would lgtm a patch that changes lld's default behavior depending on host/target only for NetBSD, and it seems like a NetBSD's issue rather than an lld's issue. As I said, could you please make an effort to pass the flags you need from the compiler driver to the linker just like other systems do? That is easy to do, doesn't hurt anyone, probably a good thing to do  anyway as it makes options explicit rather than implicit, and solves at least most of the problems you have.


We will add proper mapping for other ELF targets and everybody will benefit from a standalone linker.

As mentioned previously it will be more than standalone as we need to introduce NetBSD specific customization into target binaries that is not easily mappable from linker options (unless someone wants to switch to Linux style ELF files on NetBSD, but it won't happen). From bigger changes we plan to change DT_NEEDED semantics for NetBSD and keep catching further integration issues.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56215/new/

https://reviews.llvm.org/D56215





More information about the llvm-commits mailing list