[PATCH] D56403: add pragmas to control Software Pipelining optimisation

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

In D56403#1353857 <https://reviews.llvm.org/D56403#1353857>, @alexey.lapshin wrote:

> Would it be OK to integrate this patch in it`s current state and create another patch for warning about missed transformation for #pragma clang loop pipeline ?


Yes.

However, I don't feel qualified for reviewing this patch.



================
Comment at: lib/CodeGen/MachinePipeliner.cpp:826
+void MachinePipeliner::setPragmaPipelineOptions(MachineLoop &L) {
+
+  MachineBasicBlock *LBLK = L.getTopBlock();
----------------
[nit] unnecessary empty line


================
Comment at: lib/CodeGen/MachinePipeliner.cpp:859
+    if (S->getString() == "llvm.loop.pipeline.initiationinterval") {
+
+      assert(MD->getNumOperands() == 2 &&
----------------
[nit] unnecessary empty line


================
Comment at: lib/CodeGen/MachinePipeliner.cpp:878-880
+  if (disabledByPragma) {
+    return false;
+  }
----------------
[nit] No braces necessary


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56403/new/

https://reviews.llvm.org/D56403