[PATCH] D56582: [InstCombine]Avoid introduction of unaligned mem access

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

Code looks reasonable, but please see comment on testing strategy.



================
Comment at: test/Transforms/InstCombine/element-atomic-memintrins.ll:15
 
 define void @test_memset_to_store(i8* %dest) {
 ; CHECK-LABEL: @test_memset_to_store(
----------------
I think these changes break the spirit of the tests.  I'd recommend just providing the required alignment information on the dest argument.  And then add a separate test for the unaligned case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56582/new/

https://reviews.llvm.org/D56582