[PATCH] D56449: [UnrollRuntime] Support multi-exiting blocks to LatchExit
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 11 12:27:02 PST 2019
efriedma added inline comments.
================
Comment at: lib/Transforms/Utils/LoopUnrollRuntime.cpp:508
+ // LatchExit.
+ if (!LatchExit->getSinglePredecessor() && (UseEpilogRemainder || !DT)) {
LLVM_DEBUG(
----------------
I don't like the "!DT" check; if the domtree is required to unroll certain loops, we should just assert that the caller always passes a domtree. (I haven't reviewed the logic carefully to see if the dominates() check is strictly necessary.)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56449/new/
https://reviews.llvm.org/D56449
More information about the llvm-commits
mailing list