[PATCH] D56427: gn build: s/root_out_dir/root_build_dir/g in llvm/utils/gn/build/write_cmake_config.gni.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

In D56427#1354154 <https://reviews.llvm.org/D56427#1354154>, @thakis wrote:

> lgtm. What about the rest of `git grep root_out_dir llvm/utils/`?


Most of it seems correct, but I haven't verified it. Everything in `llvm/utils/gn/secondary/clang/include/clang` ought to be fixed though (and if I do that I can build a clang binary for Android with my other patches, which isn't all that useful for what I'm doing but it does at least serve to validate the mechanism). I'll send out a patch that does that.

In D56427#1354243 <https://reviews.llvm.org/D56427#1354243>, @phosek wrote:

> Are all the generated files independent of the target toolchain? The most idiomatic from GN point of view would be to use `root_gen_dir` for all generated files.


The second argument to `rebase_path` is the path that the result should be relative to (normally `root_build_dir` when creating arguments for an action). The output path itself is already inside `root_gen_dir`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56427/new/

https://reviews.llvm.org/D56427