[PATCH] D53890: [LTO] Record whether LTOUnit splitting is enabled in index

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:421
 
 // Returns whether this module needs to be split because it uses type metadata.
 bool requiresSplit(Module &M) {
----------------
pcc wrote:
> This comment isn't accurate anymore. I'd probably remove it since the code speaks for itself.
I updated the comment and left it, think it is useful to have a header comment.


================
Comment at: lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:442
                          Module &M, const ModuleSummaryIndex *Index) {
   // See if this module has any type metadata. If so, we need to split it.
   if (requiresSplit(M))
----------------
pcc wrote:
> Likewise
ditto


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53890/new/

https://reviews.llvm.org/D53890