[PATCH] D56587: Fix sign/zero extension in Dwarf expressions.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 11 10:22:17 PST 2019


aprantl added inline comments.


================
Comment at: lib/Transforms/Utils/Local.cpp:1863
+                                       dwarf::DW_OP_shl,
+                                       dwarf::DW_OP_or});
+        return DIExpression::appendToStack(DII.getExpression(), Ops);
----------------
General question: Should we generate a DWARF 5 type conversion here and lower it to this sequence for DWARF 4 and lower in DwarfExpression.cpp to save memory?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56587/new/

https://reviews.llvm.org/D56587





More information about the llvm-commits mailing list