[PATCH] D56577: gn build: Add a stage2 toolchain for Android.

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/utils/gn/build/toolchain/BUILD.gn:172
+    target_cflags = "$target_flags -isystem $libcxx_path/include"
+    target_ldflags = "$target_flags -fuse-ld=lld -B$platform_lib_path -L$platform_lib_path -L$libgcc_path"
+    target_ldflags +=
----------------
thakis wrote:
> The `-fuse-ld=lld` will probably need revisiting -- probably want to also add that on Linux when e.g. clang_base_path is set, and maybe if some use_lld arg is explicitly set to on. But ok for now.
I think that should also be a config that's set as a default.  If it's done that way, targets can then opt-out by using:

```
configs -= ["//build/config:lld"]
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56577/new/

https://reviews.llvm.org/D56577