[PATCH] D55763: [Sparc] Add Sparc V8 support

[James Y Knight via Phabricator via llvm-commits]

jyknight accepted this revision.
jyknight added inline comments.


================
Comment at: src/DwarfInstructions.hpp:209
 #if !defined(_LIBUNWIND_IS_NATIVE_ONLY)
-        return UNW_ECROSSRASIGNING;
+        if (R::getArch() == REGISTERS_ARM64)
+          return UNW_ECROSSRASIGNING;
----------------
I think this architecture conditional ought to be outside of the entire if block checking UNW_ARM64_RA_SIGN_STATE. LGTM other than this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55763/new/

https://reviews.llvm.org/D55763