[PATCH] D56588: [llvm-objdump] - Change the output for --all-headers.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:2304
   outs() << "start address: "
-         << "0x" << format(Fmt.data(), Address)
-         << "\n";
+         << "0x" << format(Fmt.data(), Address) << "\n\n";
 }
----------------
Won't the extra '\n' result in a weird extra blank line when printing just the file headers?

I also noticed that there was a lot of inconsistency between the different outputs in this area. What I'd like to see is each different dump to append a blank line, only if there is more to come.

I don't feel too strongly about it though, as long as we are consistent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56588/new/

https://reviews.llvm.org/D56588