[PATCH] D56580: [llvm-symbolizer] Add -exe, -e as aliases to -obj

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 11 02:01:43 PST 2019


jhenderson added inline comments.


================
Comment at: test/tools/llvm-symbolizer/sym.test:25
 RUN: llvm-symbolizer -obj=%p/Inputs/zero < %t.input | FileCheck -check-prefix="ZERO" %s
+RUN: llvm-symbolizer -exe=%p/Inputs/zero < %t.input | FileCheck -check-prefix="ZERO" %s
+RUN: llvm-symbolizer -e=%p/Inputs/zero < %t.input | FileCheck -check-prefix="ZERO" %s
----------------
I don't think this is the right test to extend this way. I would prefer either tools/llvm-symbolizer/basic.test being updated (committed very recently, so make sure you have an up-to-date checkout), or DebugInfo/llvm-symbolizer.test (see the test case within the file that uses the "BINARY" and "BINARY_C" for FileCheck prefixes).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56580/new/

https://reviews.llvm.org/D56580





More information about the llvm-commits mailing list