[PATCH] D56534: [Verifier] Add verification of unaligned atomic load/store
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 10 20:39:25 PST 2019
reames added a comment.
In D56534#1352977 <https://reviews.llvm.org/D56534#1352977>, @efriedma wrote:
> IIRC the weird LangRef definition is because it was written before we banned modules without a DataLayout.
>
> It clearly doesn't match reality, though; we generate well-defined code for unaligned atomic ops. The semantics of atomic operations in IR were changed without anyone actually updating any of the documentation (particularly around the generation of __atomic_* calls in the backend). Someone needs to go through and update it.
Do you have a pointer to an intentional change in semantics? (i.e. what changes introduced this?)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56534/new/
https://reviews.llvm.org/D56534
More information about the llvm-commits
mailing list