[PATCH] D56556: [opaque pointer types] Update CallInst creation APIs to consistently accept a callee-type argument.
whitequark via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 10 19:38:39 PST 2019
whitequark added a subscriber: echristo.
whitequark added inline comments.
================
Comment at: llvm/lib/IR/Core.cpp:3600
+ LLVMValueRef *Args, unsigned NumArgs,
+ const char *Name) {
+ FunctionType *FTy = unwrap<FunctionType>(Ty);
----------------
whitequark wrote:
> Please add `NameLen` as this is the convention for all new C APIs.
Actually, now that I think about it, making sure that every `Name` argument has a `NameLen` accompanying would involve deprecating hundreds of functions and will probably never get done. Maybe it's OK to not have `NameLen` in IRBuilder bindings.
@deadalnix @echristo your opinion on this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56556/new/
https://reviews.llvm.org/D56556
More information about the llvm-commits
mailing list