[PATCH] D56557: [opaque pointer types] Update InvokeInst creation APIs to consistently accept a callee-type argument.

whitequark via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 10 19:35:36 PST 2019


whitequark requested changes to this revision.
whitequark added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/include/llvm-c/Core.h:3411
+                              LLVMBasicBlockRef Then, LLVMBasicBlockRef Catch,
+                              const char *Name);
 LLVMValueRef LLVMBuildUnreachable(LLVMBuilderRef);
----------------
Please add `NameLen` as this is the convention for all new C APIs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56557/new/

https://reviews.llvm.org/D56557





More information about the llvm-commits mailing list