[PATCH] D53890: [LTO] Record whether LTOUnit splitting is enabled in index

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:1705
 
+  // If only some of the LTO units were split, we cannot correctly handle
+  // code that contains type tests.
----------------
I'd say "if only some of the modules were split". Same in WholeProgramDevirt.


================
Comment at: lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:421
 
 // Returns whether this module needs to be split because it uses type metadata.
 bool requiresSplit(Module &M) {
----------------
This comment isn't accurate anymore. I'd probably remove it since the code speaks for itself.


================
Comment at: lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:442
                          Module &M, const ModuleSummaryIndex *Index) {
   // See if this module has any type metadata. If so, we need to split it.
   if (requiresSplit(M))
----------------
Likewise


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53890/new/

https://reviews.llvm.org/D53890