[PATCH] D56544: [X86][AARCH64] Improve ISD::ABS support

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: test/CodeGen/AArch64/iabs.ll:46
+; CHECK-NEXT:  abs d0, d0
+; CHECK-NEXT:  fmov x0, d0
 ; CHECK-NEXT:  ret
----------------
RKSimon wrote:
> efriedma wrote:
> > This sequence is legal, but it isn't actually a good idea; the new sequence is one instruction longer, and has much higher latency.
> > 
> > AArch64TargetLowering::LowerINTRINSIC_WO_CHAIN should probably generate a v1i64 ISD::ABS, not an i64 ISD::ABS.
> Do you want me to add that change to this patch?
Probably should be a separate patch.  I'll try to take care of it soon.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56544/new/

https://reviews.llvm.org/D56544