[PATCH] D56560: [WebAssembly] Add unimplemented-simd128 subtarget feature
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 10 14:30:19 PST 2019
aheejin added inline comments.
================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrInfo.td:23
AssemblerPredicate<"FeatureSIMD128", "simd128">;
-def HasUnimplementedSIMD : Predicate<"EnableUnimplementedWasmSIMDInstrs">;
+def HasUnimplementedSIMD :
+ Predicate<"Subtarget->hasUnimplementedSIMD128()">,
----------------
aheejin wrote:
> Change this to `HasUnimplemented128` for consistency?
Oh, I meant `HasUnimplementedSIMD128`
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56560/new/
https://reviews.llvm.org/D56560
More information about the llvm-commits
mailing list