[PATCH] D56427: gn build: s/root_out_dir/root_build_dir/g in include/llvm/Config/BUILD.gn.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 10 14:23:02 PST 2019
pcc added a comment.
In D56427#1351028 <https://reviews.llvm.org/D56427#1351028>, @thakis wrote:
> There are many many references to root_out_dir, cmd-f root_out_dir on the lhs in D56487 <https://reviews.llvm.org/D56487> for example. Does it make sense to change them all at once? Or should we land D56487 <https://reviews.llvm.org/D56487> fist and at least change all the write_cmake_config ones at once?
Let's land your change first.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56427/new/
https://reviews.llvm.org/D56427
More information about the llvm-commits
mailing list