[PATCH] D56422: gn build: Use "git rev-parse --git-dir" to discover the path to the .git directory.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc marked an inline comment as done.
pcc added inline comments.


================
Comment at: llvm/utils/gn/build/write_vcsrevision.py:35
 
     if os.path.isdir(os.path.join(LLVM_DIR, '.svn')):
         print('SVN support not implemented', file=sys.stderr)
----------------
thakis wrote:
> should this use `exists()` too to be consistent with line 38?
The reason why I switched to `exists` for `.git` is that `.git` can either be a file or a directory (because of worktrees). As far as I know `.svn` will always be a directory so it seems slightly more correct to use `isdir` here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56422/new/

https://reviews.llvm.org/D56422