[PATCH] D56516: [SanitizerCoverage] Don't create comdat for weak functions.

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added a reviewer: rnk.
morehouse added a subscriber: rnk.
morehouse added a comment.

In D56516#1353359 <https://reviews.llvm.org/D56516#1353359>, @bd1976llvm wrote:

> - For ELF targets, this fix is functionally correct, but it will have the effect of retaining the section content for the weak symbols in the output, potentially slowing the link and making the output larger (unless you use -gc-sections).


Yes, but this is definitely preferred over breaking weak/strong semantics for our users.

> Hopefully, someone who is an expert on the other file formats might comment (Reid?).

@rnk:  How do weak/strong symbols in COMDATs interact on COFF?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56516/new/

https://reviews.llvm.org/D56516