[PATCH] D55881: [llvm-objcopy] [COFF] Add support for removing symbols

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

In D55881#1353296 <https://reviews.llvm.org/D55881#1353296>, @mstorsjo wrote:

> In D55881#1353276 <https://reviews.llvm.org/D55881#1353276>, @rupprecht wrote:
>
> > Just some nits, but I think this is good to commit.
>
>
> Ok - should I still wait for @jakehehrlich, or do you happen to know about his whereabouts?


IMO you can go ahead and submit now -- Jake (or anyone else) can always do a post-commit review if there are issues with this patch.



================
Comment at: tools/llvm-objcopy/COFF/Reader.cpp:87
 Error COFFReader::readSymbols(Object &Obj, bool IsBigObj) const {
+  std::vector<Symbol> Symbols;
   for (uint32_t I = 0, E = COFFObj.getRawNumberOfSymbols(); I < E;) {
----------------
mstorsjo wrote:
> rupprecht wrote:
> > Similarly you can set an initial size of `COFFObj.getRawNumberOfSymbols()` here
> Ok, will do. That'd be `Symbols.reserve(COFFObj.getRawNumberOfSymbols())` right, as it can't be done via the constructor directly?
Sounds right to me


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55881/new/

https://reviews.llvm.org/D55881