[PATCH] D56536: [clang-tidy] Fix case of local variables in modernize-use-nodiscard checker

[Eugene Zelenko via Phabricator via llvm-commits]

Eugene.Zelenko added a comment.

In D56536#1352526 <https://reviews.llvm.org/D56536#1352526>, @JonasToth wrote:

> LGTM.
>  I am in favour of running clang-tidy on LLVM (i do have a private buildbot doing so, but for testing clang-tidy itself).
>
> Take a look at `clang-tidy/utils/run-clang-tidy.py` and https://reviews.llvm.org/D54141 for speed up and better error messages, because deduplicated output.


Yes, run-clang-tidy.py is best  way to run Clang-tidy.

By the words, set of Clang-tidy checks that I run for LLVM code base cleanups. Indeed, not all of them are cleaned in same degree.

-checks="-*,clang-diagnostic-extra-semi,bugprone-suspicious-string-compare,misc-unused-using-decls,modernize-deprecated-headers,modernize-redundant-void-arg,modernize-use-auto,modernize-use-bool-literals,modernize-use-default-member-init,modernize-use-equals-default,modernize-use-equals-delete,modernize-use-nullptr,modernize-use-override,modernize-use-using,readability-container-size-empty,readability-redundant-control-flow,readability-redundant-string-cstr,readability-redundant-member-init,readability-simplify-boolean-expr,readability-static-definition-in-anonymous-namespace,readability-redundant-string-init" -config="{CheckOptions: [[:] + [bugprone-suspicious-string-compare.WarnOnLogicalNotComparison] + [,] + [value:] + ['1']]}"


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56536/new/

https://reviews.llvm.org/D56536