[PATCH] D55427: [libcxx] Call __count_bool_true for bitset count
Marshall Clow via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 10 10:28:07 PST 2019
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
After removing the `__VSTD::`, I'm good with this.
================
Comment at: include/bitset:994
{
- return static_cast<size_t>(_VSTD::count(base::__make_iter(0), base::__make_iter(_Size), true));
+ return static_cast<size_t>(_VSTD::__count_bool_true(base::__make_iter(0), _Size));
}
----------------
Don't think we need the `__VSTD::` here any more; no one should be defining their own `__count_bool_true`.
================
Comment at: include/bitset:1002
{
return _VSTD::equal(base::__make_iter(0), base::__make_iter(_Size), __rhs.__make_iter(0));
}
----------------
Have you investigated the codegen here? It seems to me that the same arguments (vectorization, alignment, etc) would apply to `operator==` as well.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55427/new/
https://reviews.llvm.org/D55427
More information about the llvm-commits
mailing list