[PATCH] D56071: [analyzer] [RetainCountChecker] Remove obsolete "MakeCollectable" enum value
George Karpenkov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 10 10:20:41 PST 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rL350860: [analyzer] [RetainCountChecker] Remove obsolete "MakeCollectable" enum value (authored by george.karpenkov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D56071?vs=179484&id=181086#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56071/new/
https://reviews.llvm.org/D56071
Files:
cfe/trunk/include/clang/StaticAnalyzer/Core/RetainSummaryManager.h
cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp
cfe/trunk/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp
Index: cfe/trunk/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp
===================================================================
--- cfe/trunk/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp
+++ cfe/trunk/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp
@@ -457,7 +457,6 @@
case Autorelease:
case DecRefBridgedTransferred:
case IncRef:
- case MakeCollectable:
case UnretainedOutParameter:
case RetainedOutParameter:
case MayEscape:
@@ -665,7 +664,7 @@
case cfretain: Effect = Effect.withKind(IncRef); break;
case cfrelease: Effect = Effect.withKind(DecRef); break;
case cfautorelease: Effect = Effect.withKind(Autorelease); break;
- case cfmakecollectable: Effect = Effect.withKind(MakeCollectable); break;
+ case cfmakecollectable: Effect = Effect.withKind(DoNothing); break;
}
ScratchArgs = AF.add(ScratchArgs, 0, Effect);
Index: cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp
===================================================================
--- cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp
+++ cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp
@@ -730,8 +730,6 @@
break;
}
}
- if (AE.getKind() == MakeCollectable)
- AE = AE.withKind(DoNothing);
// Handle all use-after-releases.
if (V.getKind() == RefVal::Released) {
@@ -741,9 +739,6 @@
}
switch (AE.getKind()) {
- case MakeCollectable:
- llvm_unreachable("MakeCollectable already converted");
-
case UnretainedOutParameter:
case RetainedOutParameter:
llvm_unreachable("Applies to pointer-to-pointer parameters, which should "
Index: cfe/trunk/include/clang/StaticAnalyzer/Core/RetainSummaryManager.h
===================================================================
--- cfe/trunk/include/clang/StaticAnalyzer/Core/RetainSummaryManager.h
+++ cfe/trunk/include/clang/StaticAnalyzer/Core/RetainSummaryManager.h
@@ -76,10 +76,6 @@
/// if CFRetain has been called on the argument.
IncRef,
- /// The argument acts as if has been passed to CFMakeCollectable, which
- /// transfers the object to the Garbage Collector under GC.
- MakeCollectable,
-
/// The argument is a pointer to a retain-counted object; on exit, the new
/// value of the pointer is a +0 value or NULL.
UnretainedOutParameter,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56071.181086.patch
Type: text/x-patch
Size: 2370 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190110/efc68c25/attachment.bin>
More information about the llvm-commits
mailing list