[PATCH] D56541: [FileCheck] Don't propagate `FILECHECK_DUMP_INPUT_ON_FAILURE` and `FILECHECK_OPTS` into environment for FileCheck tests.

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

In D56541#1352961 <https://reviews.llvm.org/D56541#1352961>, @jdenny wrote:

> In D56541#1352955 <https://reviews.llvm.org/D56541#1352955>, @delcypher wrote:
>
> > >> Okay I get the idea. This is a much more invasive change however. Would it be okay to commit this (with `FILECHECK_OPTS` also stripped out) and do your suggestion as a follow up patch?
> > >>  The reason I'd prefer to do this is because this change is intended to fix some internal build bots. Due to where we are in the release cycle the changes I make need to be simple (i.e. the smaller the patch the better) in order to be accepted by internal reviewers.
> > > 
> > > This patch does improve the situation for everyone, and it's easy to revert, so I'm fine with that.  But could you fix lit's test suite too?  Should be easy, right?  I'm not aware of any other test suites that are sensitive to FileCheck's output in this manner.
> >
> > If it's straight forward I'll land it in a separate patch.
>


I've landed a straight forward fix in r350854.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56541/new/

https://reviews.llvm.org/D56541