[PATCH] D56534: [Verifier] Add verification of unaligned atomic load/store

[JF Bastien via Phabricator via llvm-commits]

jfb added a comment.

I like the idea overall, but I think you need a way to figure out if the alignment was put there at the user's request, or if an optimization introduced it. That would allow you to turn on the check all the time, and only detect cases where LLVM messed up, instead of where it's obeying the user's request for under-alignment. Maybe clang could add a metadata node on all misaligned atomics?

I think you need to add the same thing for atomic RMW and cmpxchg.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56534/new/

https://reviews.llvm.org/D56534