[PATCH] D56535: Support MSP430
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 10 09:18:44 PST 2019
ruiu added a comment.
This patch doesn't have any test -- the test file doesn't contain any `RUN:` line, so nothing is tested so far.
================
Comment at: lld/trunk/ELF/Arch/MSP430.cpp:45
+ // mov.b #0, r3
+ TrapInstr = {0x43, 0x43};
+}
----------------
TrapInstr must be 4 bytes long. Otherwise it would create a garbage on every two bytes.
================
Comment at: lld/trunk/ELF/CMakeLists.txt:18
Arch/MipsArchTree.cpp
+ Arch/MSP430.cpp
Arch/PPC.cpp
----------------
Sort asciibetically. "MSP" should precede "Mips" in the dictionary order.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56535/new/
https://reviews.llvm.org/D56535
More information about the llvm-commits
mailing list