[PATCH] D56541: [FileCheck] Don't propagate `FILECHECK_DUMP_INPUT_ON_FAILURE` and `FILECHECK_OPTS` into environment for FileCheck tests.

[Dan Liew via Phabricator via llvm-commits]

delcypher updated this revision to Diff 181065.
delcypher added a comment.

Also unset `FILECHECK_OPTS`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56541/new/

https://reviews.llvm.org/D56541

Files:
  test/FileCheck/lit.local.cfg


Index: test/FileCheck/lit.local.cfg
===================================================================
--- /dev/null
+++ test/FileCheck/lit.local.cfg
@@ -0,0 +1,13 @@
+# Unset environment variables that the FileCheck tests
+# expect not to be set.
+file_check_expected_unset_vars = [
+  'FILECHECK_DUMP_INPUT_ON_FAILURE',
+  'FILECHECK_OPTS',
+]
+
+for env_var in file_check_expected_unset_vars:
+  if env_var in config.environment:
+    lit_config.note('Removing {} from environment for FileCheck tests'.format(
+      env_var)
+    )
+    config.environment.pop(env_var)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56541.181065.patch
Type: text/x-patch
Size: 574 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190110/a648dec6/attachment.bin>