[PATCH] D56545: [VFS] Allow multiple RealFileSystem instances with independent CWDs.

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 10 07:46:51 PST 2019


sammccall added a comment.

In D56545#1352758 <https://reviews.llvm.org/D56545#1352758>, @labath wrote:

> This usage of `Twine` isn't very nice, but neither is lambda-wrapping everything, so it's kind of a pick-your-poison situation. Anyway, just throwing the idea out there...


Thanks, I think that's a bit nicer.

I'm almost certain that ripping `Twine` out of all our filesystem interfaces would improve both performance and readability overall :-/


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56545/new/

https://reviews.llvm.org/D56545





More information about the llvm-commits mailing list