[PATCH] D56542: [llvm-symbolizer] Add -p as alias to -pretty-print

[Dmitry Venikov via Phabricator via llvm-commits]

Quolyk marked an inline comment as done.
Quolyk added inline comments.


================
Comment at: test/tools/llvm-symbolizer/sym.test:22
 RUN: llvm-symbolizer -inlining -print-address -pretty-print -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck --check-prefix="PRETTY" %s 
+RUN: llvm-symbolizer -inlining -print-address -p -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck --check-prefix="PRETTY" %s
 RUN: echo "0x1" > %t.input
----------------
jhenderson wrote:
> Quolyk wrote:
> > jhenderson wrote:
> > > Nit, here and in the line above we're being inconsistent with the number of '-' characters used to prefix options (single dash for llvm-symbolizer, double for FileCheck). It would be nice if they were consistent. I have a marginal preference for double dash, but I don't mind if you want to go the other way.
> > This is an opinionated question and I shall do as it comfortable to others for any historical reason.
> I'm not sure I understand what you mean? I think that there was no good reason to use a mixture of single and double dashes before.
> 
> You can change the other lines in the test to make them all match.
I agree, will take in account in future. I skimmed other tests and notices this pattern.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56542/new/

https://reviews.llvm.org/D56542