[PATCH] D55763: [Sparc] Add Sparc V8 support

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 10 07:12:48 PST 2019


jyknight added a comment.

In D55763#1352608 <https://reviews.llvm.org/D55763#1352608>, @dcederman wrote:

> For me native support is enough, so I removed the Sparc define from the !_LIBUNWIND_IS_NATIVE_ONLY section. That should make it compile with `-DLIBUNWIND_ENABLE_CROSS_UNWINDING=ON`.
>
> I did not see an easy way to get information about the correct architecture in parseInstructions(). If someone has a suggestion on how to best provide this information (extend the Register class with a getArch() function?) I could try it out in a subsequent patch.


I think an enum with a value for each Registers_* type, and a function in each such type to return its enum-value. Then pass that enum value as an arg to parseFDEInstructions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55763/new/

https://reviews.llvm.org/D55763





More information about the llvm-commits mailing list