[PATCH] D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: lib/CodeGen/MachineCopyPropagation.cpp:211
+  void ReadRegister(unsigned Reg, MachineInstr &Reader,
+                    bool IsDebug = false);
   void CopyPropagateBlock(MachineBasicBlock &MBB);
----------------
aprantl wrote:
> instead of an opaque optional parameter, we could also define
> ```
> enum { DebugUse = false, RegularUse = true };
> ```
> possibly with better names and explicitly pass it every time. Up to you.
Same here. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56265/new/

https://reviews.llvm.org/D56265