[PATCH] D56272: [llvm-symbolizer] Add support for specifying input addresses on the command-line

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-symbolizer/basic.s:11
+# Check input addresses specified on stdin.
+# RUN: echo -e 0xa\n0xb | llvm-symbolizer --obj=%t.o | FileCheck %s
+# RUN: echo -e 10\n11 | llvm-symbolizer --obj=%t.o < %t2.input | FileCheck %s
----------------
ruiu wrote:
> Not sure if it is safe without "". Perhaps you should add ""to be on the safe side.
I think it probably is safe, but I'll add them anyway.


================
Comment at: test/tools/llvm-symbolizer/basic.s:12
+# RUN: echo -e 0xa\n0xb | llvm-symbolizer --obj=%t.o | FileCheck %s
+# RUN: echo -e 10\n11 | llvm-symbolizer --obj=%t.o < %t2.input | FileCheck %s
+
----------------
ruiu wrote:
> Remove %t2.input.
Oops, thanks.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56272/new/

https://reviews.llvm.org/D56272