[PATCH] D56437: Support blank flag in SHT_GROUP sections for ELF

Thu Jan 10 04:01:29 PST 2019

bd1976llvm added a comment.

In D56437#1351440 <https://reviews.llvm.org/D56437#1351440>, @serge-sans-paille wrote:

> @bd1976llvm interesting. Unfortunately I failed to find this thread :-/

https://groups.google.com/d/msg/generic-abi/_CbBM6T6WeM/cSELn86gAQAJ

What I think is happening here is that a mechanism, SHF_LINK_ORDER, was introduced into ELF for marking sections as associated with other sections for the purpose of garbage collection (dead/unused section removal). However, about the same time the GUI toolchain started using non-COMDAT groups in ELF to accomplish the same goal. In order to resolve this we will either need to get agreement from GNU to use SHF_LINK_ORDER instead or we will need to implement support for non-COMDAT ELF groups in LLVM in order to be compatible.

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56437/new/

https://reviews.llvm.org/D56437