[PATCH] D56535: Support MSP430

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Arch/MSP430.cpp:63
+    if (Val & 1)
+      error(getErrorLocation(Loc) + "invalid value for relocation " +
+            toString(Type) + ": 0x" + utohexstr(Val) + " is odd");
----------------
grimar wrote:
> I would remove this.
> 
> How much is real to have this error?
> I would do just the following for start:
> 
> ```
>   case R_MSP430_16:
>   case R_MSP430_16_PCREL:
>   case R_MSP430_16_BYTE:
>   case R_MSP430_16_PCREL_BYTE:
>     checkIntUInt(Loc, Val, 16, Type);
>     write16le(Loc, Val);
> ```
> 
> Note that this is an msp430 that AFAIK has many documentation issues. I would try to with the simple as simple code as possible for now.
:] *I would try to go with the simple code as possible for now.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56535/new/

https://reviews.llvm.org/D56535