[PATCH] D55940: Detect incorrect FileCheck variable CLI definition

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: llvm/lib/Support/CommandLine.cpp:436
+  auto O = I->second;
+  if (O->getFormattingFlag() == cl::AlwaysPrefix)
+    return nullptr;
----------------
jdenny wrote:
> Is it ever possible for `O` to be nullptr here?
I guess not because in LookupNearestOption whatever option is found in OptionsMap is dereferenced without check.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55940/new/

https://reviews.llvm.org/D55940