[PATCH] D56455: [ADT] Fix SmallDenseMap assertion with large InlineBuckets

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 10 00:02:16 PST 2019


nikic added a comment.

I should probably mention that this also changes the behavior for smaller inline buckets. If say we are in the small rep with `InlineBuckets=16` and call `grow(16)`, then before this change it would switch it to the large rep with 64 buckets, while after this change it will stay in the small rep with 16 buckets. If we want to keep it this way, then an alternative fix here would be to simply adjust the assertion and allow creating a large rep with InlineBuckets buckets.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56455/new/

https://reviews.llvm.org/D56455





More information about the llvm-commits mailing list